On 15.08.2019 14:35, Andrew Lunn wrote: > On Thu, Aug 15, 2019 at 11:47:33AM +0200, Heiner Kallweit wrote: >> Now that the Realtek PHY driver maps the vendor-specific EEE registers >> to the standard MMD registers, we can remove all special handling and >> use the generic functions phy_ethtool_get/set_eee. > > Hi Heiner > Hi Andrew,
> I think you should also add a call the phy_init_eee()? > I think it's not strictly needed. And few things regarding phy_init_eee are not fully clear to me: - When is it supposed to be called? Before each call to phy_ethtool_set_eee? Or once in the drivers init path? - The name is a little bit misleading as it's mainly a validity check. An actual "init" is done only if parameter clk_stop_enable is set. - It returns -EPROTONOSUPPORT if at least one link partner doesn't advertise EEE for current speed/duplex. To me this seems to be too restrictive. Example: We're at 1Gbps/full and link partner advertises EEE for 100Mbps only. Then phy_init_eee returns -EPROTONOSUPPORT. This keeps me from controlling 100Mbps EEE advertisement. > Andrew > Heiner
