Re: [PATCH net-next 5/5] enetc: Use DT protocol information to set up the ports

[Andrew Lunn]

> +static void enetc_configure_port_mac(struct enetc_hw *hw,
> +                                  phy_interface_t phy_mode)
>  {
>       enetc_port_wr(hw, ENETC_PM0_MAXFRM,
>                     ENETC_SET_MAXFRM(ENETC_RX_MAXFRM_SIZE));
> @@ -523,9 +524,11 @@ static void enetc_configure_port_mac(struct enetc_hw *hw)
>                     ENETC_PM0_CMD_TXP | ENETC_PM0_PROMISC |
>                     ENETC_PM0_TX_EN | ENETC_PM0_RX_EN);
>       /* set auto-speed for RGMII */
> -     if (enetc_port_rd(hw, ENETC_PM0_IF_MODE) & ENETC_PMO_IFM_RG)
> +     if (enetc_port_rd(hw, ENETC_PM0_IF_MODE) & ENETC_PMO_IFM_RG ||
> +         phy_mode == PHY_INTERFACE_MODE_RGMII)
>               enetc_port_wr(hw, ENETC_PM0_IF_MODE, ENETC_PM0_IFM_RGAUTO);

What about PHY_INTERFACE_MODE_RGMII_ID, PHY_INTERFACE_MODE_RGMII_RXID
and PHY_INTERFACE_MODE_RGMII_TXID.

    Andrew