Lorenzo Bianconi <[email protected]> writes: > Always acquire tx descriptor spinlock even if a xdp program is not loaded > on the netsec device since ndo_xdp_xmit can run concurrently with > netsec_netdev_start_xmit and netsec_clean_tx_dring. This can happen > loading a xdp program on a different device (e.g virtio-net) and > xdp_do_redirect_map/xdp_do_redirect_slow can redirect to netsec even if > we do not have a xdp program on it. > > Fixes: ba2b232108d3 ("net: netsec: add XDP support") > Tested-by: Ilias Apalodimas <[email protected]> > Signed-off-by: Lorenzo Bianconi <[email protected]>
Yeah, the "must load XDP program on dest interface" pattern is not a good UI, so avoiding it when possible is good. Thanks for fixing this! Acked-by: Toke Høiland-Jørgensen <[email protected]>
