On Fri, 1 May 2020 at 15:02, Cong Wang <xiyou.wangc...@gmail.com> wrote:
>
Hi Cong,
> On Thu, Apr 30, 2020 at 12:40 AM Taehee Yoo <ap420...@gmail.com> wrote:
> > > +static void vlan_dev_set_lockdep_one(struct net_device *dev,
> > > + struct netdev_queue *txq,
> > > + void *_subclass)
> > > +{
> > > + lockdep_set_class_and_subclass(&txq->_xmit_lock,
> > > + &vlan_netdev_xmit_lock_key,
> > > + *(int *)_subclass);
> >
> > I think lockdep_set_class() is enough.
> > How do you think about it?
>
> Good catch. I overlooked this one. Is lockdep_set_class() safe
> for vlan stacked on vlan?
>
I think this is safe because of the LLTX flag.
Also, I tested nested VLAN interfaces with lockdep_set_class().
I didn't see any lockdep warning.
Thanks a lot!
Taehee Yoo
> Thanks.
