> Andrew, patch#1 in the series will parse the property to get register offset 
> and bit.
> Patch#2 describes the property format as below:
>        <&gpr req_gpr req_bit>.
>         gpr is the phandle to general purpose register node.
>         req_gpr is the gpr register offset for ENET stop request.
>         req_bit is the gpr bit offset for ENET stop request.
> 
> All i.MX support wake-on-lan, imx6q/dl/qp is the first platforms in upstream 
> to support it.
> As you know, most of i.MX chips has two ethernet instances, they have 
> different gpr bit.
> 
> gpr is used to enter/exit stop mode for soc. So it can be defined in dtsi 
> file.
> "fsl,magic-packet;" property is define the board wakeup capability.
> 
> I am not sure whether above information is clear for you why to add the patch 
> set.

I understand the patch. What is missing is an actual user, where you
have two interfaces, doing WOL, with different values for gpr. We
don't add new kernel APIs without a user.

    Andrew

Reply via email to