From: Andrew Lunn <[email protected]> Sent: Tuesday, May 26, 2020 12:06 AM > On Mon, May 25, 2020 at 04:00:29PM +0000, Andy Duan wrote: > > From: Andrew Lunn <[email protected]> Sent: Monday, May 25, 2020 10:11 > PM > > > On Mon, May 25, 2020 at 04:22:25PM +0800, Fugang Duan wrote: > > > > Add "snps,dwmac-5.10a" compatible string for 5.10a version that > > > > can avoid to define some plat data in glue layer. > > > > > > Documentation/devicetree/bindings/net/snps,dwmac.yaml ? > > > > > > Andrew > > > > Here, we don't want to use generic driver "dwmac-generic.c" for 5.10a > > version since it requires platform specific code to be functional, > > like the we implement glue layer driver "dwmac-imx.c" to support 5.10a on > i.MX platform. > > > > So I think it doesn't require to add the compatible string into dwmac.yaml. > > Hi Andy > > It needs to be documented somewhere. If not > Documentation/devicetree/bindings/net/snps,dwmac.yaml it needs to be in > an NXP specific document. > > Andrew
Yes, it can be added into NXP binding document. I wait other's comment for dwmac-imx.c driver review, then will add it together in next version. Thanks for your comments.
