Re: [greybus-dev] [PATCH 3/8] greybus: Use the new device_to_pm() helper to access struct dev_pm_ops

[Alex Elder]

On 5/25/20 1:26 PM, Krzysztof Wilczyński wrote:

Use the new device_to_pm() helper to access Power Management callbacs
(struct dev_pm_ops) for a particular device (struct device_driver).

No functional change intended.

Looks fine to me.

Reviewed-by: Alex Elder <el...@linaro.org>

Signed-off-by: Krzysztof Wilczyński <k...@linux.com>
---
  drivers/greybus/bundle.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/greybus/bundle.c b/drivers/greybus/bundle.c
index 84660729538b..d38d3a630812 100644
--- a/drivers/greybus/bundle.c
+++ b/drivers/greybus/bundle.c
@@ -108,7 +108,7 @@ static void gb_bundle_enable_all_connections(struct 
gb_bundle *bundle)
  static int gb_bundle_suspend(struct device *dev)
  {
        struct gb_bundle *bundle = to_gb_bundle(dev);
-       const struct dev_pm_ops *pm = dev->driver->pm;
+       const struct dev_pm_ops *pm = driver_to_pm(dev->driver);
        int ret;

if (pm && pm->runtime_suspend) {

@@ -135,7 +135,7 @@ static int gb_bundle_suspend(struct device *dev)
  static int gb_bundle_resume(struct device *dev)
  {
        struct gb_bundle *bundle = to_gb_bundle(dev);
-       const struct dev_pm_ops *pm = dev->driver->pm;
+       const struct dev_pm_ops *pm = driver_to_pm(dev->driver);
        int ret;

ret = gb_control_bundle_resume(bundle->intf->control, bundle->id);