Re: [PATCH net-next v5] hinic: add set_channels ethtool_ops support

[luobin (L)]

On 2020/6/2 1:53, David Miller wrote:

From: Luo bin <luob...@huawei.com>
Date: Mon, 1 Jun 2020 18:57:48 +0800

@@ -470,6 +470,11 @@ netdev_tx_t hinic_xmit_frame(struct sk_buff *skb, struct 
net_device *netdev)
        struct hinic_txq *txq;
        struct hinic_qp *qp;

+ if (unlikely(!netif_carrier_ok(netdev))) {

+               dev_kfree_skb_any(skb);
+               return NETDEV_TX_OK;
+       }

As stated by another reviewer, this change is unrelated to adding
set_channels support.  Please remove it from this patch.

Will fix. Thanks.

.