On 6/8/20 9:46 PM, Roopa Prabhu wrote:
> @@ -70,6 +71,12 @@ static int nh_dump_filter(struct nlmsghdr *nlh, int reqlen)
> return err;
> }
>
> + if (filter.fdb) {
> + addattr_l(nlh, reqlen, NHA_FDB, NULL, 0);
missing 'err = '
> + if (err)
> + return err;
> + }
> +
> return 0;
> }
>
> @@ -131,6 +138,7 @@ static int ipnh_flush(unsigned int all)
> filter.groups = 1;
> filter.ifindex = 0;
> filter.master = 0;
> + filter.fdb = 1;
This should not be needed. The point of this block is to flush groups
first and then standalone nexthops on a second pass. Adding fdb = 1 here
means only fdb groups are flushed in the first round.
