On Thu, 2020-06-18 at 12:00 -0700, Eric Dumazet wrote: > > On 6/18/20 10:31 AM, Paolo Abeni wrote: > > The sched layer can use several indirect calls per > > packet, with not work-conservative qdisc being > > more affected due to the lack of the BYPASS path. > > > > This change tries to improve the situation using > > the indirect call wrappers infrastructure for the > > qdisc enqueue end dequeue indirect calls. > > > > To cope with non-trivial scenarios, a compile-time know is > > introduced, so that the qdisc used by ICW can be different > > from the default one. > > > > Tested with pktgen over qdisc, with CONFIG_HINT_FQ_CODEL=y: > > > > qdisc threads vanilla patched delta > > nr Kpps Kpps % > > pfifo_fast 1 3300 3700 12 > > pfifo_fast 2 3940 4070 3 > > fq_codel 1 3840 4110 7 > > fq_codel 2 1920 2260 17 > > fq 1 2230 2210 -1 > > fq 2 1530 1540 1 > > Hi Paolo > > This test is a bit misleading, pktgen has a way to bypass the qdisc. > > Real numbers for more typical workloads would be more appealing, > before we consider a quite invasive patch ?
I run several tests with netperf/UDP/small packet size and different number of threads. I see a ~+2% delta with pfifo_fast single thread and difference within the noise level in all others scenarios. I'll drop this patch, thank you for the advice. Paolo
