On 2020/6/23 6:08, Jakub Kicinski wrote:
>> + if (coal->tx_max_coalesced_frames > COALESCE_MAX_PENDING_LIMIT) {
>> + netif_err(nic_dev, drv, netdev,
>> + "Tx_max_coalesced_frames out of range[%d-%d]\n", 0,
>> + COALESCE_MAX_PENDING_LIMIT);
>> + return -EOPNOTSUPP;
>> + }
>> +
>> + return 0;
>> +}
> I think ERANGE is a more appropriate error code in these?
Will fix. Thanks for your review.
- [PATCH net-next v1 0/5] hinic: add some ethtool ops support Luo bin
- [PATCH net-next v1 1/5] hinic: add support to set and ... Luo bin
- [PATCH net-next v1 2/5] hinic: add support to set and ... Luo bin
- Re: [PATCH net-next v1 2/5] hinic: add support to ... Jakub Kicinski
- Re: [PATCH net-next v1 2/5] hinic: add support to ... Jakub Kicinski
- Re: [PATCH net-next v1 2/5] hinic: add support... luobin (L)
- [PATCH net-next v1 3/5] hinic: add self test support Luo bin
- [PATCH net-next v1 4/5] hinic: add support to identify... Luo bin
- [PATCH net-next v1 5/5] hinic: add support to get eepr... Luo bin
- Re: [PATCH net-next v1 5/5] hinic: add support to ... Andrew Lunn
- Re: [PATCH net-next v1 5/5] hinic: add support to ... Jakub Kicinski
