> -----Original Message----- > From: Jakub Kicinski <k...@kernel.org> > Sent: Friday, June 26, 2020 12:00 PM > To: Kirsher, Jeffrey T <jeffrey.t.kirs...@intel.com> > Cc: da...@davemloft.net; Michael, Alice <alice.mich...@intel.com>; > netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com; > Brady, Alan <alan.br...@intel.com>; Burra, Phani R <phani.r.bu...@intel.com>; > Hay, Joshua A <joshua.a....@intel.com>; Chittim, Madhu > <madhu.chit...@intel.com>; Linga, Pavan Kumar > <pavan.kumar.li...@intel.com>; Skidmore, Donald C > <donald.c.skidm...@intel.com>; Brandeburg, Jesse > <jesse.brandeb...@intel.com>; Samudrala, Sridhar > <sridhar.samudr...@intel.com> > Subject: Re: [net-next v3 09/15] iecm: Init and allocate vport > > On Thu, 25 Jun 2020 19:07:31 -0700 Jeff Kirsher wrote: > > @@ -532,7 +540,12 @@ static void iecm_service_task(struct work_struct > *work) > > */ > > static void iecm_up_complete(struct iecm_vport *vport) { > > - /* stub */ > > + netif_set_real_num_rx_queues(vport->netdev, vport->num_txq); > > + netif_set_real_num_tx_queues(vport->netdev, vport->num_rxq); > > These can fail. > > > + netif_carrier_on(vport->netdev); > > + netif_tx_start_all_queues(vport->netdev); > > + > > + vport->adapter->state = __IECM_UP; > > }
Will fix, thanks -Alan