Jarek Poplawski wrote: > On 14-03-2007 23:49, Patrick McHardy wrote: > ... > >>I noticed this a couple of times, but didn't manage to look >>into it yet: >> >>BUG: sleeping function called from invalid context at mm/slab.c:3032 >>in_atomic():1, irqs_disabled():0 >>no locks held by ip/14309. >> >>Call Trace: >> [<ffffffff810956e9>] debug_show_held_locks+0x9/0xb >> [<ffffffff8100b0b0>] __might_sleep+0xd9/0xdb >> [<ffffffff8100f745>] __kmalloc_track_caller+0x67/0x10f >> [<ffffffff810aaff1>] __kzalloc+0x15/0x2f >> [<ffffffff811fc5a5>] tnode_new+0x55/0x122 > > > tnode_alloc() uses GFP_KERNEL ... > > >> [<ffffffff811fcc88>] resize+0x616/0x966 >> [<ffffffff811d2e08>] nlmsg_notify+0x43/0x6f >> [<ffffffff811fd074>] trie_rebalance+0x9c/0xef >> [<ffffffff811fd231>] trie_leaf_remove+0x16a/0x1c2 > > > ... but we have preempt_disable() here.
Yes, Robert already sent me a patch to remove the bogus preempt_disable, but IIRC it was there to make sure changes to the tree don't interfere with packet processing, so we might need to do something else. I'll try to look into it later today. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
