On 7/10/20, 1:05 PM, "Jakub Kicinski" <k...@kernel.org> wrote:
On Fri, 10 Jul 2020 19:53:46 +0000 Machulsky, Zorik wrote:
> On 7/9/20, 1:24 PM, "Jakub Kicinski" <k...@kernel.org> wrote:
>
> On Thu, 9 Jul 2020 22:05:01 +0300 akiy...@amazon.com wrote:
> > From: Arthur Kiyanovski <akiy...@amazon.com>
> >
> > Add the rss_configurable_function_key bit to
driver_supported_feature.
> >
> > This bit tells the device that the driver in question supports the
> > retrieving and updating of RSS function and hash key, and therefore
> > the device should allow RSS function and key manipulation.
> >
> > Signed-off-by: Arthur Kiyanovski <akiy...@amazon.com>
>
> Is this a fix of the previous patches? looks strange to just start
> advertising a feature bit but not add any code..
>
> The previous related commits were merged already:
> 0af3c4e2eab8 net: ena: changes to RSS hash key allocation
> c1bd17e51c71 net: ena: change default RSS hash function to Toeplitz
> f66c2ea3b18a net: ena: allow setting the hash function without changing
the key
> e9a1de378dd4 net: ena: fix error returning in ena_com_get_hash_function()
> 80f8443fcdaa net: ena: avoid unnecessary admin command when RSS function
set fails
> 6a4f7dc82d1e net: ena: rss: do not allocate key when not supported
> 0d1c3de7b8c7 net: ena: fix incorrect default RSS key
These commits are in net.
> This commit was not included by mistake, so we are adding it now.
You're adding it to net-next.
This commit actually enables a feature after it was fixed by previous commits,
therefore we thought
that net-next could be a right place. But if you think it should go to net,
we'll go ahead and resubmit
it there. Thanks for your comments.
