Kees Cook <[email protected]> wrote: > Using uninitialized_var() is dangerous as it papers over real bugs[1] > (or can in the future), and suppresses unrelated compiler warnings (e.g. > "unused variable"). If the compiler thinks it is uninitialized, either > simply initialize the variable or make compiler changes. As a precursor > to removing[2] this[3] macro[4], just initialize this variable to NULL. > No later NULL deref is possible due to the early returns outside of the > (phy->rev >= 7 && phy->rev < 19) case, which explicitly tests for NULL. > > [1] https://lore.kernel.org/lkml/[email protected]/ > [2] > https://lore.kernel.org/lkml/CA+55aFw+Vbj0i=1tgqcr5vqkczwj0qxk6cernou6eedsuda...@mail.gmail.com/ > [3] > https://lore.kernel.org/lkml/ca+55afwgbgqhbp1fkxvrkepzyr5j8n1vkt1vzdz9knmpuxh...@mail.gmail.com/ > [4] > https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yvju65tplgn_ybynv0ve...@mail.gmail.com/ > > Fixes: 58619b14d106 ("b43: move under broadcom vendor directory") > Signed-off-by: Kees Cook <[email protected]> > Reviewed-by: Nick Desaulniers <[email protected]>
2 patches applied to wireless-drivers-next.git, thanks. 800e7a205a0f b43: Remove uninitialized_var() usage f8279dad4e36 rtlwifi: rtl8192cu: Remove uninitialized_var() usage -- https://patchwork.kernel.org/patch/11615573/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
