On Mon, 13 Jul 2020 21:50:25 +0100 Matthew Hagan wrote: > + u32 val = qca8k_read(priv, QCA8K_REG_PORT0_PAD_CTRL);
> + val |= QCA8K_PORT0_PAD_CTRL_MAC06_EXCHG; > + val |= QCA8K_PORT0_PAD_SGMII_RXCLK_FALLING_EDGE; > + val |= QCA8K_PORT0_PAD_SGMII_TXCLK_FALLING_EDGE; > + qca8k_write(priv, QCA8K_REG_PORT0_PAD_CTRL, val); > + val = qca8k_read(priv, reg); > + val |= QCA8K_PORT_PAD_RGMII_EN; > + qca8k_write(priv, reg, val); > + val |= QCA8K_PORT_PAD_RGMII_EN | > + QCA8K_PORT_PAD_RGMII_TX_DELAY(QCA8K_MAX_DELAY) | > + QCA8K_PORT_PAD_RGMII_RX_DELAY(QCA8K_MAX_DELAY); > + qca8k_write(priv, reg, val); > + val |= QCA8K_PORT_PAD_SGMII_EN; > + qca8k_write(priv, reg, val); Since throughout the patch you're only setting bits perhaps qca8k_reg_set() would be a better choice than manually reading and then writing?
