On Sat, Aug 01, 2020 at 09:32:04PM -0700, Jakub Kicinski wrote: > On Sat, 1 Aug 2020 22:52:42 +0200 Armin Wolf wrote: > > Replace version string with MODULE_* macros. > > > > Include necessary libraries. > > > > Fix two minor coding-style issues. > > > > Signed-off-by: Armin Wolf <[email protected]> > > This doesn't build but also > > ../drivers/net/ethernet/8390/lib8390.c:973:17: error: undefined identifier > 'version' > In file included from ../include/linux/kernel.h:15, > from ../drivers/net/ethernet/8390/8390.c:9: > ../drivers/net/ethernet/8390/lib8390.c: In function ‘ethdev_setup’: > ../drivers/net/ethernet/8390/lib8390.c:973:17: error: ‘version’ undeclared > (first use in this function) > 973 | pr_info("%s", version); > | ^~~~~~~ > ../include/linux/printk.h:368:34: note: in definition of macro ‘pr_info’ > 368 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) > | ^~~~~~~~~~~ > ../drivers/net/ethernet/8390/lib8390.c:973:17: note: each undeclared > identifier is reported only once for each function it appears in > 973 | pr_info("%s", version); > | ^~~~~~~ > ../include/linux/printk.h:368:34: note: in definition of macro ‘pr_info’ > 368 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) > | ^~~~~~~~~~~ > make[5]: *** [../scripts/Makefile.build:281: > drivers/net/ethernet/8390/8390.o] Error 1 > make[4]: *** [../scripts/Makefile.build:497: drivers/net/ethernet/8390] Error > 2 > make[4]: *** Waiting for unfinished jobs.... > make[3]: *** [../scripts/Makefile.build:497: drivers/net/ethernet] Error 2 > make[3]: *** Waiting for unfinished jobs.... > make[2]: *** [../scripts/Makefile.build:497: drivers/net] Error 2 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [/netdev/net-next/Makefile:1771: drivers] Error 2 > make: *** [Makefile:185: __sub-make] Error 2
Did you apply patch 2/2 of the patchset? Because version-printing (and the need for a version string) was removed from lib8390.c in patch 2/2 to allow the replacement of said version-string with MODULE_* macros in 8390.c, and failing to do so whould result in the exact same error.
