On Wed, 21 Mar 2007, Guennadi Liakhovetski wrote:

On Wed, 21 Mar 2007, Samuel Ortiz wrote:

I'm quite sure the leak is in the IrDA code rather than in the ppp or
ipv4 one, hence the need for full irda debug...

Well, looks like you were wrong, Samuel. Below is a patch that fixes ONE sk_buff leak (maintainer added to cc: hi, Paul:-)). Still investigating if there are more there.

Thanks
Guennadi
---------------------------------
Guennadi Liakhovetski, Ph.D.
DSA Daten- und Systemtechnik GmbH
Pascalstr. 28
D-52076 Aachen
Germany

Don't leak an sk_buff on interface destruction.

Signed-off-by: G. Liakhovetski <[EMAIL PROTECTED]>

--- a/drivers/net/ppp_generic.c 2007-03-23 13:04:04.000000000 +0100
+++ b/drivers/net/ppp_generic.c 2007-03-23 13:05:29.000000000 +0100
@@ -2544,6 +2544,9 @@
        ppp->active_filter = NULL;
 #endif /* CONFIG_PPP_FILTER */

+       if (ppp->xmit_pending)
+               kfree_skb(ppp->xmit_pending);
+
        kfree(ppp);
 }

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to