On Mon, 2007-03-26 at 13:39 -0600, Joy Latten wrote:
> +                     if ((err = security_xfrm_policy_delete(pol)) != 0) {
> +                             xfrm_audit_log(audit_info->loginuid,
> +                                            audit_info->secid,
> +                                            AUDIT_MAC_IPSEC_DELSPD,
> +                                            err ? 0 : 1, pol, NULL);
> +                             return err;

In all of the denial log statements you keep the "err ? 0 : 1" which are
common among audit, but in this patch we always know that err is 1. Is
it worth simplifying this down to just a 0 in the all of the
xfrm_audit_log calls?

-Eric

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to