On Thu, 1 Oct 2020 12:52:33 -0700 [email protected] wrote:
> From: Shay Drory <[email protected]>
>
> On error flow due to failure on driver load, driver can be
> un-initializing while a health work is running in the background,
> health work shouldn't be allowed at this point, as it needs resources to
> be initialized and there is no point to recover on driver load failures.
>
> Therefore, introducing a new state bit to indicated if device is
> initialized, for health work to check before trying to recover the driver.
Can't you cancel this work? Or make sure it's not scheduled?
IMHO those "INITILIZED" bits are an anti-pattern.
> Fixes: b6e0b6bebe07 ("net/mlx5: Fix fatal error handling during device load")
> Signed-off-by: Shay Drory <[email protected]>
> Signed-off-by: Saeed Mahameed <[email protected]>
> Signed-off-by: Saeed Mahameed <[email protected]>
You signed off twice :)
We should teach verify_signoff to catch that..
