On Fri, 2 Oct 2020 11:09:43 +0200 Johannes Berg wrote: > From: Johannes Berg <[email protected]> > > We'll need this later for the per-op policy index dump. > > Signed-off-by: Johannes Berg <[email protected]>
Reviewed-by: Jakub Kicinski <[email protected]> > while (netlink_policy_dump_loop(ctx->state)) { > - void *hdr; > + void *hdr = ctrl_dumppolicy_prep(skb, cb); > struct nlattr *nest; > > - hdr = genlmsg_put(skb, NETLINK_CB(cb->skb).portid, > - cb->nlh->nlmsg_seq, &genl_ctrl, > - NLM_F_MULTI, CTRL_CMD_GETPOLICY); > if (!hdr) > goto nla_put_failure; bike shedding, but I find it less pretty when functions which require error checking are called as variable init (if it's not the only variable declared).
