Jeff Garzik <[EMAIL PROTECTED]> wrote:
>
>> @@ -2778,12 +2778,12 @@ int dev_ioctl(unsigned int cmd, void __user *arg)
>>
>> if (cmd == SIOCGIFCONF) {
>> rtnl_lock();
>> - ret = dev_ifconf((char __user *) arg);
>> + ret = dev_ifconf(arg);
>> rtnl_unlock();
>> - return ret;
>> }
>> +
>> if (cmd == SIOCGIFNAME)
>> - return dev_ifname((struct ifreq __user *)arg);
>> + return dev_ifname(arg);
>
> Seems like a net loss of information, with your patch.
>
> The casts are adding missing type information, in this case. Certainly
> it is more for human consumption than compiler consumption, but
> nonetheless...
How about just getting rid of the casts? 'arg' is already void * to
begin with.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
