On Thu, Oct 22, 2020 at 2:48 PM Jakub Kicinski <k...@kernel.org> wrote: > > Latest fixes from the networking tree. Experimenting with the format > of the description further, I'll find out if you liked it based on how > it ends up looking in the tree :)
Looks fine to me. Honestly, the format isn't a huge deal, as long as it's understandable. But I do like the grouping, since that increases legibility. A lot of my editing of these things end up being about trying to make the merge messages from different people look somewhat uniform (a couple of common patterns, and generally a somewhat common indentation policy etc). And yours have already been closer to the norm than David's numbering is, for example. But I don't get _too_ hung up about it, the most important thing by far is that I get a feeling for the overview of the changes, and that I feel the commit message is useful and sensible for others that are interested in what's going on (ie I will generally try to edit out things like "This pull request does XYZ", because that kind of language makes no sense once it's a merge commit in the history). Linus