On 11/6/20 9:03 AM, Jakub Kicinski wrote:
On Thu, 5 Nov 2020 16:12:18 -0800 Shannon Nelson wrote:
+ work = kzalloc(sizeof(*work), GFP_ATOMIC);
+ if (!work) {
+ netdev_err(lif->netdev, "%s OOM\n", __func__);
+ return;
+ }
Can you drop this message (can be a follow up, since you're just moving
it).
AFAICT ATOMIC doesn't imply NOWARN so the message is redundant no?
Yes, this can probably be cleaned up. There are several of these left
over from the very early version of this driver that I'd like to clean
up, but haven't yet bubbled up high enough on my priority-vs-time list.
I'll try to get to them in the next week or so.
sln
