On Sun, 22 Nov 2020 09:19:05 +0200 Shay Agroskin wrote: > Jakub Kicinski <[email protected]> writes: > > > On Thu, 19 Nov 2020 22:28:51 +0200 Shay Agroskin wrote: > >> The function mistakenly returns NETDEV_TX_OK regardless of the > >> transmission success. This patch fixes this behavior by > >> returning the > >> error code from the function. > >> > >> Fixes: 548c4940b9f1 ("net: ena: Implement XDP_TX action") > >> Signed-off-by: Shay Agroskin <[email protected]> > > > > Doesn't seem like a legitimate bug fix, since the only caller of > > this > > function ignores its return value. > > Hi, > I plan to use the return value from this function in future patch > (next-net series), do you think we better send this fix with > this future patch?
Yes, it's fine to include this in a net-next series. It doesn't fix any bug that could cause trouble to the users. If you had a fix that depended on it then maybe, but if you only need it in net-next we can put it there with clear conscience.
