From: Arnd Bergmann <[email protected]>
This is the fourth version of my series, now spanning four patches
instead of two, with a new approach for handling struct ifreq
compatibility after I realized that my earlier approach introduces
additional problems.
The idea here is to always push down the compat conversion
deeper into the call stack: rather than pretending to be
native mode with a modified copy of the original data on
the user space stack, have the code that actually works on
the data understand the difference between native and compat
versions.
I have spent a long time looking at all drivers that implement
an ndo_do_ioctl callback to verify that my assumptions are
correct. This has led to a series of 29 additional patches
that I am not including here but will post separately, fixing
a number of bugs in SIOCDEVPRIVATE ioctls, removing dead
code, and splitting ndo_do_ioctl into two new ndo callbacks
for private and ethernet specific commands.
The patches are identical to v3 that I sent a few weeks ago,
except this avoids the build failure when CONFIG_COMPAT is
disabled.
Arnd
Changes in v4:
- build fix without CONFIG_INET
- build fix without CONFIG_COMPAT
- style fixes pointed out by hch
Changes in v3:
- complete rewrite of the series
Arnd Bergmann (4):
ethtool: improve compat ioctl handling
net: socket: rework SIOC?IFMAP ioctls
net: socket: simplify dev_ifconf handling
net: socket: rework compat_ifreq_ioctl()
include/linux/compat.h | 82 +++++------
include/linux/ethtool.h | 4 -
include/linux/inetdevice.h | 9 ++
include/linux/netdevice.h | 12 +-
net/appletalk/ddp.c | 4 +-
net/core/dev_ioctl.c | 152 ++++++++++---------
net/ethtool/ioctl.c | 143 ++++++++++++++++--
net/ieee802154/socket.c | 4 +-
net/ipv4/af_inet.c | 6 +-
net/ipv4/devinet.c | 4 +-
net/qrtr/qrtr.c | 4 +-
net/socket.c | 289 ++++++++-----------------------------
12 files changed, 338 insertions(+), 375 deletions(-)
Cc: "David S. Miller" <[email protected]>
Cc: Jakub Kicinski <[email protected]>
Cc: Christoph Hellwig <[email protected]>
Cc: Jiri Pirko <[email protected]>
Cc: Taehee Yoo <[email protected]>
Cc: Eric Dumazet <[email protected]>
Cc: Alexei Starovoitov <[email protected]>
Cc: Andrew Lunn <[email protected]>
Cc: [email protected]
Cc: [email protected]
--
2.27.0
