On Sat, 5 Dec 2020 13:57:18 -0800 Jakub Kicinski wrote: > On Thu, 3 Dec 2020 19:51:28 -0800 Jonathan Lemon wrote: > > +static int __init > > +ptp_ocp_init(void) > > +{ > > + int err; > > + > > + err = pci_register_driver(&ptp_ocp_driver); > > + return err; > > +} > > + > > +static void __exit > > +ptp_ocp_fini(void) > > +{ > > + pci_unregister_driver(&ptp_ocp_driver); > > +} > > + > > +module_init(ptp_ocp_init); > > +module_exit(ptp_ocp_fini); > > FWIW if you want to send a follow up you can replace all this with: > > module_pci_driver(ptp_ocp_driver);
Also consider adding yourself a MAINTAINERS entry.