From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 10 May 2007 21:55:17 +1000
> Thomas Graf <[EMAIL PROTECTED]> wrote: > > When transmit fails with NETDEV_TX_LOCKED the skb is requeued > > to dev->qdisc again. The dev->qdisc pointer is protected by > > the queue lock which needs to be dropped when attempting to > > transmit and acquired again before requeing. The problem is > > that qdisc_restart() fetches the dev->qdisc pointer once and > > stores it in the `q' variable which is invalidated when > > dropping the queue_lock, therefore the variable needs to be > > refreshed before requeueing. > > > > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> > > I agree, good catch Thomas. Applied to my tree and I'll push it off to Linus tomorrow unless someone finds a problem with it by then. Thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
