Hi Marek,

I love your patch! Yet something to improve:

[auto build test ERROR on net/master]
[also build test ERROR on ipvs/master net-next/master linus/master v5.11-rc2 
next-20210104]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Marek-Vasut/net-phy-micrel-Add-KS8851-PHY-support/20210104-203217
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 
4bfc4714849d005e6835bcffa3c29ebd6e5ee35d
config: i386-randconfig-a013-20210105 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # 
https://github.com/0day-ci/linux/commit/ab74850be61e7510a3304091c458b8aedfd51388
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review 
Marek-Vasut/net-phy-micrel-Add-KS8851-PHY-support/20210104-203217
        git checkout ab74850be61e7510a3304091c458b8aedfd51388
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>

All errors (new ones prefixed by >>):

   ld: drivers/net/ethernet/micrel/ks8851_common.o: in function 
`ks8851_register_mdiobus':
>> drivers/net/ethernet/micrel/ks8851_common.c:1103: undefined reference to 
>> `__this_module'


vim +1103 drivers/net/ethernet/micrel/ks8851_common.c

  1085  
  1086  static int ks8851_register_mdiobus(struct ks8851_net *ks, struct device 
*dev)
  1087  {
  1088          struct mii_bus *mii_bus;
  1089          int ret;
  1090  
  1091          mii_bus = mdiobus_alloc();
  1092          if (!mii_bus)
  1093                  return -ENOMEM;
  1094  
  1095          mii_bus->name = "ks8851_eth_mii";
  1096          mii_bus->read = ks8851_mdio_read;
  1097          mii_bus->write = ks8851_mdio_write;
  1098          mii_bus->priv = ks;
  1099          mii_bus->parent = dev;
  1100          mii_bus->phy_mask = ~((u32)BIT(0));
  1101          snprintf(mii_bus->id, MII_BUS_ID_SIZE, "%s", dev_name(dev));
  1102  
> 1103          ret = mdiobus_register(mii_bus);
  1104          if (ret)
  1105                  goto err_mdiobus_register;
  1106  
  1107          ks->mii_bus = mii_bus;
  1108  
  1109          return 0;
  1110  
  1111  err_mdiobus_register:
  1112          mdiobus_free(mii_bus);
  1113          return ret;
  1114  }
  1115  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

Reply via email to