> For lockless drivers, I think it could be moved up; only > thing is nothing is stopping it from changing again at transmit time. > For drivers that are not lockless, i am wondering if its even > useful to have that check given we have already grabbed the tx lock.
Good point. I live in an LLTX world, so I don't think tx_lock mode very often. > > > That > > way you still hold dev->queue_lock in case the queue is > stopped, and > > haven't yet pulled an skb causing a requeue event. > > It certainly sounds like a useful optimization. Defer that > thought - for now i just want to make sure its doing what the > previous code did. Agreed. > > I will repost the fixed patch later today after some testing; > if you have time i will appreciate some eyeballing. That > piece of code is hairy. Hopefully we can make it bald. Clippers are standing by. :) -PJ - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html