Le 14/01/2021 à 02:29, Jakub Kicinski a écrit :
[snip]
> --- a/net/ipv6/sit.c
> +++ b/net/ipv6/sit.c
> @@ -1645,8 +1645,11 @@ static int ipip6_newlink(struct net *src_net, struct
> net_device *dev,
> }
>
> #ifdef CONFIG_IPV6_SIT_6RD
> - if (ipip6_netlink_6rd_parms(data, &ip6rd))
> + if (ipip6_netlink_6rd_parms(data, &ip6rd)) {
> err = ipip6_tunnel_update_6rd(nt, &ip6rd);
> + if (err)
nit: I would prefer 'if (err < 0)' to be consistent with the rest of the sit
code, but it's purely aesthetic (ipip6_tunnel_update_6rd() returns a negative
value or 0).
With or without this:
Acked-by: Nicolas Dichtel <[email protected]>
> + unregister_netdevice_queue(dev, NULL);
> + }
> #endif
>
> return err;
>
