On Thu, Feb 4, 2021 at 8:18 PM Joakim Zhang <[email protected]> wrote: > > > > -----Original Message----- > > From: Willem de Bruijn <[email protected]> > > Sent: 2021年2月4日 21:20 > > To: Joakim Zhang <[email protected]> > > Cc: Giuseppe Cavallaro <[email protected]>; Alexandre Torgue > > <[email protected]>; Jose Abreu <[email protected]>; David > > Miller <[email protected]>; Jakub Kicinski <[email protected]>; Network > > Development <[email protected]>; Andrew Lunn <[email protected]>; > > Florian Fainelli <[email protected]>; Willem de Bruijn > > <[email protected]> > > Subject: Re: [PATCH net-next 2/2] net: stmmac: slightly adjust the order of > > the > > codes in stmmac_resume() > > > > On Thu, Feb 4, 2021 at 5:18 AM Joakim Zhang <[email protected]> > > wrote: > > > > > > Slightly adjust the order of the codes in stmmac_resume(), remove the > > > check "if (!device_may_wakeup(priv->device) || !priv->plat->pmt)". > > > > > > Signed-off-by: Joakim Zhang <[email protected]> > > > > This commit message says what the code does, but not why or why it's > > correct. > > This just slight changes the code order, there is no function change, I will > improve the commit message if needed.
And it is correct to move this phylink initialization before serdes_powerup? That is not immediately obvious to me. A comment would definitely be good. More relevant than just stating that the code is moved, which I see from the patch easily.
