On Thu, May 24, 2007 at 05:20:24PM -0400, Jeff Garzik wrote: > Linas Vepstas wrote: > >Don't run any of the MSI handlers if the channel is off; > >also don't gather device statatistics. Also, netif_wake > >not needed, per suggestions from > >Sivakumar Subramani <[EMAIL PROTECTED]>. > > > Why are the interrupt handlers being called at all, then? > > This seems to be papering over another bug.
Ahh ... are you suggesting that the arch should be performing this check in driver-independent code, and not delivering the MSI if the pci channel is deemed offline? Yes, right, good point. So far, I'd hadn't really given this much thought, and had been letting the dev drivers perform this check, but, yes, it is probably better to have one common check performed in the generic arch-specific code, and the interrupt dropped, if the device is offlined. I'll look into this. --linas - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
