On Thu, Feb 25, 2021 at 6:46 PM Jason A. Donenfeld <ja...@zx2c4.com> wrote:
>
> There were a few remaining tunnel drivers that didn't receive the prior
> conversion to icmp{,v6}_ndo_send. Knowing now that this could lead to
> memory corrution (see ee576c47db60 ("net: icmp: pass zeroed opts from
> icmp{,v6}_ndo_send before sending") for details), there's even more
> imperative to have these all converted. So this commit goes through the
> remaining cases that I could find and does a boring translation to the
> ndo variety.
>
> Cc: Willem de Bruijn <will...@google.com>
> Signed-off-by: Jason A. Donenfeld <ja...@zx2c4.com>Using a stack variable over skb->cb[] is definitely the right fix for all of these. Thanks Jason. Only part that I don't fully know is the conntrack conversion. That is a behavioral change. What is the context behind that? I assume it's fine. In that if needed, that is the case for all devices, nothing specific about the couple that call icmp(v6)_ndo_send already.
