From: Geliang Tang <geliangt...@gmail.com>

This patch adds testcases for signalling multi valid and invalid
addresses for both signal_address_tests and remove_tests.

Signed-off-by: Geliang Tang <geliangt...@gmail.com>
Signed-off-by: Mat Martineau <mathew.j.martin...@linux.intel.com>
---
 .../testing/selftests/net/mptcp/mptcp_join.sh | 58 +++++++++++++++++++
 1 file changed, 58 insertions(+)

diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh 
b/tools/testing/selftests/net/mptcp/mptcp_join.sh
index 32379efa2276..679de3abaf34 100755
--- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
+++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
@@ -785,6 +785,28 @@ signal_address_tests()
        run_tests $ns1 $ns2 10.0.1.1
        chk_join_nr "multiple subflows and signal" 3 3 3
        chk_add_nr 1 1
+
+       # signal addresses
+       reset
+       ip netns exec $ns1 ./pm_nl_ctl limits 3 3
+       ip netns exec $ns1 ./pm_nl_ctl add 10.0.2.1 flags signal
+       ip netns exec $ns1 ./pm_nl_ctl add 10.0.3.1 flags signal
+       ip netns exec $ns1 ./pm_nl_ctl add 10.0.4.1 flags signal
+       ip netns exec $ns2 ./pm_nl_ctl limits 3 3
+       run_tests $ns1 $ns2 10.0.1.1
+       chk_join_nr "signal addresses" 3 3 3
+       chk_add_nr 3 3
+
+       # signal invalid addresses
+       reset
+       ip netns exec $ns1 ./pm_nl_ctl limits 3 3
+       ip netns exec $ns1 ./pm_nl_ctl add 10.0.12.1 flags signal
+       ip netns exec $ns1 ./pm_nl_ctl add 10.0.3.1 flags signal
+       ip netns exec $ns1 ./pm_nl_ctl add 10.0.14.1 flags signal
+       ip netns exec $ns2 ./pm_nl_ctl limits 3 3
+       run_tests $ns1 $ns2 10.0.1.1
+       chk_join_nr "signal invalid addresses" 1 1 1
+       chk_add_nr 3 3
 }
 
 link_failure_tests()
@@ -896,6 +918,30 @@ remove_tests()
        chk_add_nr 1 1
        chk_rm_nr 2 2
 
+       # addresses remove
+       reset
+       ip netns exec $ns1 ./pm_nl_ctl limits 3 3
+       ip netns exec $ns1 ./pm_nl_ctl add 10.0.2.1 flags signal id 250
+       ip netns exec $ns1 ./pm_nl_ctl add 10.0.3.1 flags signal
+       ip netns exec $ns1 ./pm_nl_ctl add 10.0.4.1 flags signal
+       ip netns exec $ns2 ./pm_nl_ctl limits 3 3
+       run_tests $ns1 $ns2 10.0.1.1 0 -3 0 slow
+       chk_join_nr "remove addresses" 3 3 3
+       chk_add_nr 3 3
+       chk_rm_nr 3 3 invert
+
+       # invalid addresses remove
+       reset
+       ip netns exec $ns1 ./pm_nl_ctl limits 3 3
+       ip netns exec $ns1 ./pm_nl_ctl add 10.0.12.1 flags signal
+       ip netns exec $ns1 ./pm_nl_ctl add 10.0.3.1 flags signal
+       ip netns exec $ns1 ./pm_nl_ctl add 10.0.14.1 flags signal
+       ip netns exec $ns2 ./pm_nl_ctl limits 3 3
+       run_tests $ns1 $ns2 10.0.1.1 0 -3 0 slow
+       chk_join_nr "remove invalid addresses" 1 1 1
+       chk_add_nr 3 3
+       chk_rm_nr 3 1 invert
+
        # subflows and signal, flush
        reset
        ip netns exec $ns1 ./pm_nl_ctl limits 0 3
@@ -930,6 +976,18 @@ remove_tests()
        chk_join_nr "flush addresses" 3 3 3
        chk_add_nr 3 3
        chk_rm_nr 3 3 invert
+
+       # invalid addresses flush
+       reset
+       ip netns exec $ns1 ./pm_nl_ctl limits 3 3
+       ip netns exec $ns1 ./pm_nl_ctl add 10.0.12.1 flags signal
+       ip netns exec $ns1 ./pm_nl_ctl add 10.0.3.1 flags signal
+       ip netns exec $ns1 ./pm_nl_ctl add 10.0.14.1 flags signal
+       ip netns exec $ns2 ./pm_nl_ctl limits 3 3
+       run_tests $ns1 $ns2 10.0.1.1 0 -8 0 slow
+       chk_join_nr "flush invalid addresses" 1 1 1
+       chk_add_nr 3 3
+       chk_rm_nr 3 1 invert
 }
 
 add_tests()
-- 
2.31.0

Reply via email to