Re: [PATCH net-next v3 04/18] net: phy: marvell10g: indicate 88X33x0 only port control registers

[Andrew Lunn]

> @@ -479,8 +479,8 @@ static int mv3310_config_init(struct phy_device *phydev)
>       val = phy_read_mmd(phydev, MDIO_MMD_VEND2, MV_V2_PORT_CTRL);
>       if (val < 0)
>               return val;
> -     priv->rate_match = ((val & MV_V2_PORT_CTRL_MACTYPE_MASK) ==
> -                     MV_V2_PORT_CTRL_MACTYPE_RATE_MATCH);
> +     priv->rate_match = ((val & MV_V2_33X0_PORT_CTRL_MACTYPE_MASK) ==
> +                     MV_V2_33X0_PORT_CTRL_MACTYPE_RATE_MATCH);
>  
>       /* Enable EDPD mode - saving 600mW */
>       return mv3310_set_edpd(phydev, ETHTOOL_PHY_EDPD_DFLT_TX_MSECS);
> -- 

So it appears that mv3310_config_init() should not be used with the
mv88x2110. Did i miss somewhere where mv3310_drivers was changed so it
actually does not use it?

         Andrew