[EMAIL PROTECTED] <[EMAIL PROTECTED]> :
[...]
> Please review and provide comments.
o ixgbe_call_func and the ton of wrappers which go along with it
should go.
o boolean_t duplicates the existing 'bool'
o The options below {should be/are} handled through ethtool:
- TxDescriptors
- RxDescriptors
- XsumRX
o No __iomem annotations ?
o pci_alloc_consistent() returns a zeroed area: no need for memset.
o ixgbe_clean_tx_irq() is issued from the NAPI poll handler (as the
name suggests...). Its locking will probably cause a deadlock if
it is interrupted and a call to netpoll_send_skb follows.
--
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
