Re: [PATCH v2 net-next 1/5] net: dsa: mv88e6xxx: Mark chips with undocumented EDSA tag support

[Florian Fainelli]

On 4/15/2021 2:26 AM, Tobias Waldekranz wrote:
> All devices are capable of using regular DSA tags. Support for
> Ethertyped DSA tags sort into three categories:
> 
> 1. No support. Older chips fall into this category.
> 
> 2. Full support. Datasheet explicitly supports configuring the CPU
>    port to receive FORWARDs with a DSA tag.
> 
> 3. Undocumented support. Datasheet lists the configuration from
>    category 2 as "reserved for future use", but does empirically
>    behave like a category 2 device.
> 
> So, instead of listing the one true protocol that should be used by a
> particular chip, specify the level of support for EDSA (support for
> regular DSA is implicit on all chips). As before, we use EDSA for all
> chips that fully supports it.
> 
> In upcoming changes, we will use this information to support
> dynamically changing the tag protocol.
> 
> Signed-off-by: Tobias Waldekranz <tob...@waldekranz.com>

Reviewed-by: Florian Fainelli <f.faine...@gmail.com>
-- 
Florian