On Sat, 17 Apr 2021 22:22:57 +0300 Ido Schimmel wrote: > > > So you will have something like: > > > > > > ETHTOOL_A_STATS_GRP_HIST_BKT_UNITS_BYTES > > > > Histogram has two dimensions, what's the second dimension for bytes? > > Time? Packet arrival? > > Not sure what you mean. Here you are counting how many Rx/Tx packets are > between N to M bytes in length. I meant to add two attributes. One that > tells user space that you are counting Rx/Tx packets and the second that > N to M are in bytes.
Ah, these were not part of the same enum, I get it now. I thought maybe bytes were trying to cater to the queue length use case and I wasn't sure how that histogram is constructed. > But given your comment below about this histogram probably being a one > time thing, I think maybe staying with the current attributes is OK. > There is no need to over-engineer it if we don't see ourselves adding > new histograms. > > Anyway, these histograms are under ETHTOOL_A_STATS_GRP that should give > user space all the context about what is being counted.
