On 1/22/26 3:51 PM, Michael S. Tsirkin wrote: >> + ethtool_group.group_priority = >> cpu_to_le16(VIRTNET_FF_ETHTOOL_GROUP_PRIORITY); >> + >> + /* Use priority for the object ID. */ >> + err = virtio_admin_obj_create(vdev, >> + VIRTIO_NET_RESOURCE_OBJ_FF_GROUP, >> + VIRTNET_FF_ETHTOOL_GROUP_PRIORITY, > > This (3rd param to virtio_admin_obj_create) > is the object ID actually. Setting this to 1 means it is outside > of range for group limit which should be 0...limit - 1 and limit is 1. > > don't you mean 0? >
No, the the maximum number of groups being 1 doesn't say anything about the ID you use for that group. Higher IDs indicate higher priorities. I intentionally choose 1 here because a reasonable follow on series would be to implement ARFS. In that case it would make sense to have user created rules higher priority than ARFS rules. > >> + VIRTIO_ADMIN_GROUP_TYPE_SELF,
