On Thu, Jun 11, 2026 at 10:27:42AM +0200, Stefano Garzarella wrote: > Maybe adding a new function that moves a socket from the pending queue > to the accept queue avoiding also sock_put/sock_hold dance and > sk_acceptq_removed()/sk_acceptq_added(). > > To be called in vmci_transport_recv_connecting_server(). > > So can we move sk_acceptq_added() also in vsock_add_pending()?
I like the vsock_pending_to_accept() approach, it makes the vmci path clean without the double-accounting issue. Will send a v3 series with that as patch 1, followed by folding sk_acceptq_added() into vsock_add_pending() and sk_acceptq_removed() into vsock_remove_pending() as separate patches. Any preference on the name xd? vsock_pending_to_accept() works for me. Raf
