On Fri, Jun 12, 2026 at 04:52:14AM +0000, Raf Dickson wrote: > Move sk_acceptq_added() into vsock_add_pending() so callers cannot > forget it. vmci is the only transport using the pending list and > is updated accordingly. > > Suggested-by: Stefano Garzarella <[email protected]> > Signed-off-by: Raf Dickson <[email protected]> > --- > net/vmw_vsock/af_vsock.c | 1 + > net/vmw_vsock/vmci_transport.c | 1 - > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c > index 1f94f0d44c..6cfa89b6f3 100644 > --- a/net/vmw_vsock/af_vsock.c > +++ b/net/vmw_vsock/af_vsock.c > @@ -483,6 +483,7 @@ void vsock_add_pending(struct sock *listener, struct sock > *pending) > sock_hold(pending); > sock_hold(listener); > list_add_tail(&vpending->pending_links, &vlistener->pending_links); > + sk_acceptq_added(listener); > } > EXPORT_SYMBOL_GPL(vsock_add_pending); > > diff --git a/net/vmw_vsock/vmci_transport.c b/net/vmw_vsock/vmci_transport.c > index 635ebf9da4..c2db016cca 100644 > --- a/net/vmw_vsock/vmci_transport.c > +++ b/net/vmw_vsock/vmci_transport.c > @@ -1109,7 +1109,6 @@ static int vmci_transport_recv_listen(struct sock *sk, > } > > vsock_add_pending(sk, pending); > - sk_acceptq_added(sk); > > pending->sk_state = TCP_SYN_SENT; > vmci_trans(vpending)->produce_size = > -- > 2.54.0 >
Reviewed-by: Bobby Eshleman <[email protected]>
