Waskiewicz Jr, Peter P wrote:
>>You're right, thats a bug. TC_H_ROOT is the parent ID, which
>>is stored in sch->parent. IIRC its also passed to the
>>->init() function.
>
>
> Unfortunately it's not passed. It is passed into the ->change()
> function:
>
> static int prio_init(struct Qdisc *sch, struct rtattr *opt)
>
> static int prio_change(struct Qdisc *sch, u32 handle, u32 parent, struct
> rtattr **tca, unsigned long *arg)
>
> I did mess around with sch->parent a bit, with no success (it appears to
> be zero / unitialized). I'll keep investigating.
Its set after grafting the parent, which is after initialization.
I think what should work is to set it in qdisc_create instead,
sch_api.c around line 490:
+ sch->parent = handle;
if (handle == TC_H_INGRESS) {
sch->flags |= TCQ_F_INGRESS;
sch->stats_lock = &dev->ingress_lock;
...
and remove the initialization in qdisc_graft. That would additionally
have the benefit that ingress qdiscs also have it initialized properly.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
