Krishna Kumar wrote:
Doing napi_disable twice hangs "ifdown" of the device. e1000_down is the common place to call napi_disable.Signed-off-by: Krishna Kumar <[EMAIL PROTECTED]> --- e1000_main.c | 4 ---- 1 files changed, 4 deletions(-) diff -ruNp org/drivers/net/e1000/e1000_main.c new/drivers/net/e1000/e1000_main.c --- org/drivers/net/e1000/e1000_main.c 2007-08-23 13:32:16.000000000 +0530 +++ new/drivers/net/e1000/e1000_main.c 2007-08-23 13:32:34.000000000 +0530 @@ -1477,10 +1477,6 @@ e1000_close(struct net_device *netdev) { struct e1000_adapter *adapter = netdev_priv(netdev);-#ifdef CONFIG_E1000_NAPI- napi_disable(&adapter->napi); -#endif - WARN_ON(test_bit(__E1000_RESETTING, &adapter->flags)); e1000_down(adapter); e1000_power_down_phy(adapter);
Acked-by: Auke Kok <[EMAIL PROTECTED]> I pushed this change to akpm for -mm as well in e1000e... Thanks Krishna, Auke - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
