David Miller <[EMAIL PROTECTED]> writes: > From: [EMAIL PROTECTED] (Eric W. Biederman) > Date: Wed, 26 Sep 2007 17:53:40 -0600 > >> >> This patch add support for dynamically allocating the statistics counters >> for the loopback device and adds appropriate device methods for allocating >> and freeing the loopback device. >> >> This completes support for creating multiple instances of the loopback >> device, in preparation for creating per network namespace instances. >> >> Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> > > Applied to net-2.6.24, thanks. > >> @@ -155,7 +154,8 @@ static int loopback_xmit(struct sk_buff *skb, struct > net_device *dev) >> dev->last_rx = jiffies; >> >> /* it's OK to use __get_cpu_var() because BHs are off */ >> - lb_stats = &__get_cpu_var(pcpu_lstats); >> + pcpu_lstats = netdev_priv(dev); >> + lb_stats = per_cpu_ptr(pcpu_lstats, smp_processor_id()); >> lb_stats->bytes += skb->len; >> lb_stats->packets++; >> > > I'm going to add a followon change that gets rid of that > comment about __get_cpu_var() since it is no longer > relevant.
Good point. I'm not doing get_cpu/put_cpu so does the comment make sense in relationship to per_cpu_ptr? Eric - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
