> -----Original Message----- > From: Medve Emilian-EMMEDVE1 > Sent: Monday, October 15, 2007 9:44 PM > To: [EMAIL PROTECTED]; [EMAIL PROTECTED]; Li > Yang-r58472; netdev@vger.kernel.org; [EMAIL PROTECTED] > Cc: Medve Emilian-EMMEDVE1 > Subject: [PATCH v2] [POWERPC] ucc_geth: Fix build break > introduced by commit 09f75cd7bf13720738e6a196cc0107ce9a5bd5a0 > > drivers/net/ucc_geth.c: In function 'ucc_geth_rx': > drivers/net/ucc_geth.c:3483: error: 'dev' undeclared (first > use in this function) > drivers/net/ucc_geth.c:3483: error: (Each undeclared > identifier is reported only once > drivers/net/ucc_geth.c:3483: error: for each function it appears in.) > make[2]: *** [drivers/net/ucc_geth.o] Error 1 > > Signed-off-by: Emil Medve <[EMAIL PROTECTED]>
Acked-by: Li Yang <[EMAIL PROTECTED]> > --- > > Here is a convenient link for the culprit patch: > http://git.kernel.org/?p=linux/kernel/git/jgarzik/netdev-2.6.g > it;a=commit;h=09f75cd7bf13720738e6a196cc0107ce9a5bd5a0 > > netdev-2.6> scripts/checkpatch.pl > 0001-POWERPC-ucc_geth-Fix-build-break-introduced-by-co.patch > Your patch has no obvious style problems and is ready for submission. > > drivers/net/ucc_geth.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c > index d00e7d4..bec413b 100644 > --- a/drivers/net/ucc_geth.c > +++ b/drivers/net/ucc_geth.c > @@ -63,7 +63,7 @@ > #define UGETH_MSG_DEFAULT (NETIF_MSG_IFUP << 1 ) - 1 > > void uec_set_ethtool_ops(struct net_device *netdev); > - > + > static DEFINE_SPINLOCK(ugeth_lock); > > static struct { > @@ -3454,9 +3454,12 @@ static int ucc_geth_rx(struct > ucc_geth_private *ugeth, u8 rxQ, int rx_work_limit > u16 length, howmany = 0; > u32 bd_status; > u8 *bdBuffer; > + struct net_device * dev; > > ugeth_vdbg("%s: IN", __FUNCTION__); > > + dev = ugeth->dev; > + > /* collect received buffers */ > bd = ugeth->rxBd[rxQ]; > > -- > 1.5.3.GIT > - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
