Krishna Kumar2 写道:
> Gui Jianfeng wrote on 10/22/2007 11:37:07 AM:
>
>> @@ -310,8 +310,12 @@ static inline int ip_rcv_finish(struct s
>> * how the packet travels inside Linux networking.
>> */
>> if (skb->dst == NULL) {
>> - if (ip_route_input(skb, iph->daddr, iph->saddr, iph->tos, dev))
>> - goto drop;
>> + int err = ip_route_input(skb, iph->daddr, iph->saddr, iph->tos,
> dev);
>> + if (unlikely(err)) {
>> + if (err == -EHOSTUNREACH)
>> + IP_INC_STATS_BH(IpInAddrErrors);
>> + }
>> + goto drop;
>> }
>
> Shouldn't the "goto drop" be inside the "if (unlikely(err)) {" case?
yes, you are right :-)
> And normally it is nice to have a blank line after variable declaration.
>
> - KK
>
>
>
--
Regards
Gui Jianfeng
--------------------------------------------------
Gui Jianfeng
Development Dept.I
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)
8/F., Civil Defense Building, No.189 Guangzhou Road,
Nanjing, 210029, China
TEL: +86+25-86630566-851
COINS: 79955-851
FAX: +86+25-83317685
MAIL:[EMAIL PROTECTED]
--------------------------------------------------
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
