On Mon, 22 Oct 2007 02:05:38 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote:
> From: Pierre Ossman <[EMAIL PROTECTED]> > Date: Mon, 22 Oct 2007 10:42:08 +0200 > > > This seems like a rather evil layering violation. > > This has a 10+ year precedence and it's why the Linux networking stack > is so fast. If you read any other driver you would have seen the > skb_reserve() call every one of them do to align the headers. > The norm seems to be to not comment this call. It's hardly obvious. > I think I've tolerated this long enough. > > Are you going keep teaching me how the C language works, how GCC > interprets it, and how evil the Linux networking is, or are you going > to fix the bug in your driver? :-) Settle down, "bug" fixed even before this discussion even began. I just don't like papering over problems so I want to know why this is needed and if it isn't indicative of a larger problem. If you don't want the discussions, make sure people know the gotchas. (And I wasn't try to teach anyone. I was giving my view on things, and if you think I'm off my meds, feel free to say so. Groveling and excessively putting every statement as a question demeans us both. ;)) Rgds Pierre
signature.asc
Description: PGP signature
