Hi Grant,
Grant Likely schrieb:
> From: Grant Likely <[EMAIL PROTECTED]>
>
> Driver shouldn't complain if the register range is larger than what
> it expects. This works around failures with some device trees.
>
But maybe the firmware guys like to know about it?
May I suggest putting this in front of the other check?
if ((mem.end - mem.start + 1) > sizeof(struct mpc52xx_fec)) {
printk(KERN_DEBUG DRIVER_NAME
" - gratious resource size (%lx > %x), check
mpc52xx_devices.c\n",
(unsigned long)(mem.end - mem.start + 1), sizeof(struct
mpc52xx_fec));
}
> - if ((mem.end - mem.start + 1) != sizeof(struct mpc52xx_fec)) {
> + if ((mem.end - mem.start + 1) < sizeof(struct mpc52xx_fec)) {
> printk(KERN_ERR DRIVER_NAME
> - " - invalid resource size (%lx != %x), check
> mpc52xx_devices.c\n",
> + " - invalid resource size (%lx < %x), check
> mpc52xx_devices.c\n",
> (unsigned long)(mem.end - mem.start + 1), sizeof(struct
> mpc52xx_fec));
> return -EINVAL;
> }
Best Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
