On Fri, 2007-11-30 at 07:56 +0000, Christoph Hellwig wrote: > > > > This patch adds BCM5248 and Marvell 88E1111 PHY support to NEW EMAC > driver. > > These PHY chips are used on PowerPC 440EPx boards. > > The PHY code is based on the previous work by Stefan Roese > <[EMAIL PROTECTED]> > > Is there a reason the emac driver isn't using the generic phy code?
Yes. First, the emac PHY code predates the generic one, and mostly, in its current shape, the generic PHY code does too violent locking for me. I need to be able to use mutexes in the low level PHY read/write, and the current phylib doesn't allow that as it uses spinlocks all over. However, I do plan to fix that. I haven't had time yet, but I plan to convert PHY lib to more task-level operations, which would be a good thing anyway since PHY communication is fairly slow and some chips can do it interrupt driven rather than polling loops (and even polling loops could be preemptible). So the answer is "not yet" basically. Cheers, Ben. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
